-
Notifications
You must be signed in to change notification settings - Fork 346
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update paimon.md #1472
Update paimon.md #1472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thank you very much for improving the Paimon WPS, the example code looks great and it will definitely help new users to getting started!
Head branch was pushed to by a user without write access
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The example code is using the Wechaty v0.x API, which can not work with the latest Wechaty v1.x.
My suggestion will be:
- use the Wechaty v1.x API to prevent confusion when a user is getting started
- use TypeScript so that the code can be static typing
- use ESM so that we can use the
import
as well as the top-levelasync
/await
(ESM will be the default after Wechaty v2.0, and therequire
might be deprecated)
I want keep it so simple.Some users can't understand typescript. |
Head branch was pushed to by a user without write access
Please make sure to check the following boxes creating your pull request, thank you very much!
Add Blog Header, including title, author, image, categories, tags, etc.
For example:
Keep all filenames lowercase, and use
-
to connect words instead of space. e.g.2017-10-06-wechat-pc-impactor.md
instead of2017-10-06-WeChat PC Impactor.md
Embed video/pdf from YouTube/Bilibili/local (if there's any) by using
{% include iframe.html src="URL_or_PATH" %}
. (Learn more about how to embed file/url in the post by reading this blog postSave photo to local before publishing, to a folder named by
${MONTH}-${YOUR_BLOG_SLUG}/
under/assets/2021/
directory.Select a beautiful and meaningful teaser image for your blog
Create your contributor profile (if you are a first time contributor)
For excample:
Here is the example file:
To learn more about the contribute guideline, visit: https://wechaty.js.org/docs/contributor-program/